Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add QBO and "raw manifests" guides table #3700

Closed
wants to merge 1 commit into from
Closed

add QBO and "raw manifests" guides table #3700

wants to merge 1 commit into from

Conversation

thesuperzapper
Copy link
Member

Based on my comments in #3672 (comment), I think there is a need to distinguish "guides" from distributions.

To help @alexeadem get a presence on the website, I think QBO can be the first such guide.

All other existing distributions have forked the kubeflow/manifests repo, and made at least some platform-specific changes. We can discuss if any of the existing "packaged distributions" should be moved to the "guides for specific platforms" table in future PRs.

Changes

  • Adds a "guides for specific platforms" section under "raw kubeflow manifests"
  • Adds QBO to the "guides for specific platforms" table
  • Moves the "packaged distributions note" to the bottom of the "packaged distributions" section:
    • this is an unrelated change, but I think it makes the page more readable, as it currently interrupts the reader a lot

Screenshot

Installing-Kubeflow-Kubeflow

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thesuperzapper
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski March 20, 2024 02:41
@thesuperzapper thesuperzapper mentioned this pull request Mar 20, 2024
Merged
@thesuperzapper
Copy link
Member Author

@andreyvelich @james-jwu @jbottum based on my comments in #3672 (comment), I think it makes more sense to introduce a "platform-specific guides" section under "raw kubeflow manifests" so we can include things which really aren't "packaged distributions" on the website.

The first one can be the QBO guide.

See the screenshot above.

@StefanoFioravanzo StefanoFioravanzo mentioned this pull request Apr 15, 2024
Open
10 tasks
hbelmiro
hbelmiro reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for review

@andreyvelich @james-jwu @jbottum can you PTAL?

@google-oss-prow google-oss-prow bot added the lgtm label Jun 7, 2024
@rimolive
Copy link
Member

rimolive commented Jun 7, 2024

There are merge conflicts. @thesuperzapper would you mind fix these conflicts?

@thesuperzapper
Copy link
Member Author

@rimolive @hbelmiro this PR is stale, we ended up just adding QBO to the distributions list in #3672.

@thesuperzapper thesuperzapper deleted the raw-manifests-guides-table branch June 8, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@alfsuse alfsuse Awaiting requested review from alfsuse

@knkski knkski Awaiting requested review from knkski

Assignees

@hbelmiro hbelmiro

Labels
do-not-merge/hold lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesuperzapper @rimolive @hbelmiro